Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] World metrics don't work on Folia #233

Open
sladkoff opened this issue Feb 29, 2024 · 0 comments
Open

[Bug Report] World metrics don't work on Folia #233

sladkoff opened this issue Feb 29, 2024 · 0 comments

Comments

@sladkoff
Copy link
Owner

sladkoff commented Feb 29, 2024

  • ⚒️ Metrics mc_entities_total, mc_villagers_total will need to be re-implemented to use the new RegionScheduler class. It is no longer possible to call World#getEntities from the main thread.
    • If we use the regionised scheduling, we can add the label region to the metric and the total entity counts can be aggregated by Prometheus/Grafana.
    • It should also be possible to use an event-based approach (see Improve performance of chunk loaded metric and offline player count  #226). Basically, we can subscribe to entity load/unload events and count entities that way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant