Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to specify csvSettingsDetector #113

Open
deadsoul44 opened this issue Nov 22, 2022 · 4 comments
Open

option to specify csvSettingsDetector #113

deadsoul44 opened this issue Nov 22, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@deadsoul44
Copy link

Motivation
I am using a different text delimiter. Slang cannot parse my csv.

Developer Experience
There should be an option to specify csvSettingsDetector.

var d = new FirstOccurrenceSettingsDetector(eols: ['\r\n', '\n'], textDelimiters: ['"', "'"]);
new CsvToListConverter(csvSettingsDetector: d);
@deadsoul44 deadsoul44 added the enhancement New feature or request label Nov 22, 2022
@Tienisto
Copy link
Member

Thanks for this issue!

I think that your solution is good enough to be default as it supports both CRLF and LF, " and '.

Released in v3.5.0.

@deadsoul44
Copy link
Author

Actually, I use a different delimiter and wanted to specify it as a parameter. I checked the changelog, docs, tests and couldn’t see that kind of parameter. I guess you added the above as builtin default values.

@Tienisto
Copy link
Member

Alright, sorry. Yep, this is now default. I guess this parameter is missing in the config file.

@Tienisto Tienisto reopened this Nov 24, 2022
@deadsoul44
Copy link
Author

Friendly reminder :) This is the only blocking issue to switch from another localization package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants