Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scope-> GroupName mapping #184

Closed
leonqadirie opened this issue Nov 19, 2023 · 3 comments
Closed

Add Scope-> GroupName mapping #184

leonqadirie opened this issue Nov 19, 2023 · 3 comments

Comments

@leonqadirie
Copy link
Contributor

leonqadirie commented Nov 19, 2023

Relating to #177 (comment):

This is where having another index might be helpful, i.e. Scope -> Group name in a separate mapping. But that's an optimization that can be added in the future.

To make sure I understand you correctly before tackling this:
Are we talking about sth. along the lines of substituting ScopeGroupKey with sth. like this?

pub struct Scope {
    name: ScopeName,
    groups: HashSet<GroupName>,
}
@slawlor
Copy link
Owner

slawlor commented Dec 7, 2023

Sorry again on the delay getting back to you. I meant another global index linking the scopes to groups. So you could efficiently lookup the groups from a given scope. This would remove some scan operations but it is a minimal operation.

@leonqadirie
Copy link
Contributor Author

No problem, again, take all the time required. Hope all is fine and you get some sleep ;)
Will open a PR with what I understood this to be.

@slawlor
Copy link
Owner

slawlor commented Feb 8, 2024

#190 resolved this.

@slawlor slawlor closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants