Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not depend protobuf-src on windows #228

Closed
hemaolong opened this issue Apr 22, 2024 · 2 comments
Closed

Not depend protobuf-src on windows #228

hemaolong opened this issue Apr 22, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@hemaolong
Copy link

Is your feature request related to a problem? Please describe.
The ractor_cluster can not compile on windows.

Describe the solution you'd like
Do not depend the protobuf-src and use the protoc directly(Can find by the ENV).

fn build_protobufs() {
        if cfg!(windows){
            if std::env::var("PROTOC").is_err(){
                panic!("Set protoc.exe path to the PROTOC!");
            }
        }
        else{
            std::env::set_var("PROTOC", protobuf_src::protoc());
        }
    
        //    ...
    }
@hemaolong hemaolong added the enhancement New feature or request label Apr 22, 2024
@slawlor
Copy link
Owner

slawlor commented Apr 27, 2024

Please feel free to submit a Windows specific pr! I don't have an environment to test this with easily so feel free to contribute

@slawlor
Copy link
Owner

slawlor commented Dec 17, 2024

I believe this is fixed with #296 since we now use vendored protoc instead of building it from source.

@slawlor slawlor closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants