Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BookshelfPlural gets created with New tag and receives a SacrificeID #10

Open
NeunEinser opened this issue May 11, 2020 · 0 comments · May be fixed by #13
Open

BookshelfPlural gets created with New tag and receives a SacrificeID #10

NeunEinser opened this issue May 11, 2020 · 0 comments · May be fixed by #13

Comments

@NeunEinser
Copy link

The New tag gets added for every unique item.
Plurals usually do not receive any SacrificeID.

However, for the bookshelf plural, both the new tag is added and afterwards the assignid function is called as well. This causes BookshelfPlural to receive a sacrifice ID.

I don't know whether this might mess anything else up.
@MalbaCato MalbaCato linked a pull request Jul 25, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved readability in setuptargets + misc. fixes MalbaCato/Sacrifice
1 participant
@NeunEinser