Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved readability in setuptargets + misc. fixes #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improved readability in setuptargets + misc. fixes #13

wants to merge 2 commits into from

Conversation

MalbaCato
Copy link

Main improvement:
Condensed all calls to praise:assignid into a single call at the end of the file.

Smaller tweaks:

@MalbaCato MalbaCato marked this pull request as ready for review October 21, 2020 20:20
@MalbaCato
Copy link
Author

So I finally remembered to check that it works, and the item sequence was identical, on both vanilla 1.16.3 and a fabric installation on the latest version of Java.
Tested for 10 in-game days. Thus I conclude that it works.

@MalbaCato MalbaCato closed this Jul 19, 2021
@MalbaCato MalbaCato reopened this Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BookshelfPlural gets created with New tag and receives a SacrificeID
1 participant
@MalbaCato