Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading behavior when setting at to 0 #1611

Open
mathias-ewald opened this issue May 24, 2024 · 0 comments
Open

Misleading behavior when setting at to 0 #1611

mathias-ewald opened this issue May 24, 2024 · 0 comments
Labels
clicks system about clicks animations enhancement New feature or request

Comments

@mathias-ewald
Copy link

mathias-ewald commented May 24, 2024

By @KermanX:

The current behavior when setting at to 0 on magic-move and v-switch is quite misleading. Setting at to 0 should means this first state shows without a click, but currently it shows the second state and skips the first state. Because changing the behavior will be a breaking change, a warning should be made when 0 is set, and the at value should fall back to 1.


Original content:

Describe the bug

As magic-move transitions through different versions of the code block, it is not possible to render HTML in lock step. V-click or v-switch elements, given the correct at attribute, do not show at the expected click.

To Reproduce
Steps to reproduce the behavior:

  1. Run the example in the code pasted below
  2. On click, I would expect the 2nd block of code to show together with template 1
  3. See how that's not the case

slides.md

Desktop (please complete the following information):

  • OS: MacOS Sonoma 14.5
  • Browser: Firefox
  • Slidev version: 0.49.3
@KermanX KermanX self-assigned this May 24, 2024
@KermanX KermanX changed the title Magic move and v-click cannot be synchronized Misleading behavior when setting at to 0 May 24, 2024
@KermanX KermanX removed their assignment May 24, 2024
@KermanX KermanX added enhancement New feature or request clicks system about clicks animations labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clicks system about clicks animations enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants