Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onBeforeUnmount never called #1679

Open
louwers opened this issue Jun 17, 2024 · 1 comment
Open

onBeforeUnmount never called #1679

louwers opened this issue Jun 17, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation planned pr welcome

Comments

@louwers
Copy link

louwers commented Jun 17, 2024

Describe the bug
I would expect onBeforeUnmount to be called when the next slide is shown and a component goes off screen. However, it isn't, and there is no information about the Vue lifecycle in the documentation.

To Reproduce
Steps to reproduce the behavior:

  1. Create a custom component, call the onBeforeUnmount lifecycle function
  2. Add it to a slide
  3. Observe that it is never called

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Chrome
  • Slidev version: 0.49.10
@louwers
Copy link
Author

louwers commented Jun 17, 2024

I can work around this with #1550

But it would still be good to mention that Vue's usual lifecycle hooks don't apply.

@KermanX KermanX added documentation Improvements or additions to documentation planned pr welcome labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation planned pr welcome
Projects
None yet
Development

No branches or pull requests

2 participants