Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vscode): migrate to reactive-vscode #1673

Merged
merged 10 commits into from
Jul 13, 2024

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Jun 15, 2024

This PR migrates the VSCode extension to reactive-vscode.

Pros:

  • No need to maintain some common composables
  • Smaller bundled size (reactive-vscode doesn't depend on @vue/runtime-core)

Cons:

  • reactive-vscode isn't stable yet. So the version is pinned

Copy link

netlify bot commented Jun 15, 2024

👷 Deploy Preview for slidev processing.

Name Link
🔨 Latest commit da73e19
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/666d18ce9843f40008e31ef0

Copy link

netlify bot commented Jun 15, 2024

Deploy Preview for slidev failed.

Name Link
🔨 Latest commit da73e19
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/666d18ce9843f40008e31ef0

Copy link

netlify bot commented Jun 15, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 1a7eaad
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/668e7883b6f69100085f4405
😎 Deploy Preview https://deploy-preview-1673--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KermanX KermanX marked this pull request as ready for review July 10, 2024 11:50
@antfu antfu changed the title refactor: migrate to reactive-vscode refactor(vscode): migrate to reactive-vscode Jul 13, 2024
@antfu antfu merged commit 4f20e30 into slidevjs:main Jul 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants