erb2slim doesn't handle ERB fragments within a tag definition properly

[MrJoy]

This:

<tr>
  <td class="firstcol <%= ' first_row_cell'.html_safe if params[:iphone] -%>">
    <%= f.label :login, "Email" %>
  </td>
  <td <%= 'class="first_row_cell"'.html_safe if params[:iphone] -%> >
    <%= f.text_field 'login', :value => base_login, :class => 'textfield', :placeholder => '[email protected]' %> 
  </td>
</tr>

Becomes:

tr
  |  <td class="firstcol 
  = ' first_row_cell'.html_safe if params[:iphone] -
  | "> 
  = f.label :login, "Email"
  |  <td 
  = 'class="first_row_cell"'.html_safe if params[:iphone] -
  |  > 
  = f.text_field 'login', :value => base_login, :class => 'textfield', :placeholder => '[email protected]'

[defaye]

I'm assuming I've experienced the same issue:

erb code:

  <div id='category_<%= category.id %>' class='category'>

conversion expectation:

  .category id="category_#{category.id}" 

actual conversion error:

  #category_<ruby code="= category.id"></ruby>.category

[joaomilho]

Yes, that's a problem. Will take a look into it ASAP.

[joaomilho]

So I took a look and given the (hacky) way we do erb parsing on it it's going to be a lil tricky. But I'm still thinking about a proper solution.

[joaomilho]

You're right about the expected output on ruby inside an attribute, but on ruby inside a tag this is the right output:

  <td <%= 'class="first_row_cell"'.html_safe if params[:iphone] -%> >

  td class=("first_row_cell"'.html_safe if params[:iphone])