Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double values in blocklocator.json file #117

Closed
buhtignew opened this issue Jun 6, 2024 · 1 comment
Closed

Double values in blocklocator.json file #117

buhtignew opened this issue Jun 6, 2024 · 1 comment
Labels
info Just to share some info question Further information is requested

Comments

@buhtignew
Copy link
Collaborator

I've discovered that some blockheight is mentioned twice in my blocklocator.json file (
blocklocator.json
Specifically 156889 and 381560 is it expected?

@buhtignew buhtignew added question Further information is requested info Just to share some info labels Jun 6, 2024
@d5000
Copy link

d5000 commented Jun 8, 2024

This was fixed in the commits up to 7c31f67. I had seen the part of the command which could have caused the duplicates, and changed that part so it doesn't happen again (blockheights which are already in the JSON files simply aren't stored).

The duplicates which are there now aren't deleted, but as new cachings should never lead to duplicates again I don't think such an "auto-cleaning" measure is needed, it would only bloat the code and make everything slower. What you can do is clean duplicates manually if you want, or erase the affected addresses with address cache ADDR -e.

If everything is ok please close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info Just to share some info question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants