Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create issues even when workflow is invalid #29

Open
ianlewis opened this issue Jun 7, 2022 · 4 comments
Open

Create issues even when workflow is invalid #29

ianlewis opened this issue Jun 7, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@ianlewis
Copy link
Member

ianlewis commented Jun 7, 2022

If the path or names of inputs to the reusable workflow are not correct then the e2e test workflow doesn't run at all and doesn't create GitHub issues. We need to find a way to have issues created even when the workflow is invalid.

@laurentsimon
Copy link
Collaborator

definitely helpful. I did not do it to simplify the workflows, but I agree it's needed to catch other errors.

@ianlewis
Copy link
Member Author

ianlewis commented Jun 11, 2022

Yeah, right now if you do a reusable workflow call and the inputs dont match up, Github Actions says the whole workflow is invalid and doesn't do anything else and doesn't run our 'if-failed` job so we don't get an issue created. The only notification we get is maybe 1 of tons of spam email from Github Actions telling us the run failed. It's hard to sift through.

@ianlewis
Copy link
Member Author

Related to #204 and #202

@ianlewis ianlewis added the enhancement New feature or request label Jun 12, 2023
@ianlewis
Copy link
Member Author

actionlint should hopefully catch when the workflow itself is invalid though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants