Undefined variable in ->getObjectsByType('EmbeddedFile') but there is an attachment inside given

[PrimeGhostDE]

• PHP Version: 8.2
• PDFParser Version: 2.11.0 (newest)

Description:

I have analyzed the bug so far, that there is a problem concerning embeddedFiles.

PDF input

Example pdf invoice.
Rechnung RE-202400282 vom 09.10.2024 zu Ihr Zeichen.pdf

Expected output & actual output

There is only one embedded File in it (please ignore why i use foreach here)

$pdfParser = new PdfParser();
$pdfParsed = $pdfParser->parseContent($pdfContent);
$filespecs = $pdfParsed->getObjectsByType('Filespec');

foreach ($filespecs as $filespec) {
  $filespecDetails = $filespec->getDetails();
  // Output:
  array:7 [
    "AFRelationship" => "Alternative"
    "Desc" => "ZUGFeRD 2.1 Rechnung"
    "EF" => array:1 [
      "F" => array:3 [
        "DL" => "22974"
        "Length" => "1871"
        "Subtype" => "text/xml"
      ]
    ]
    "F" => "factur-x.xml"
    "Subtype" => "text/xml"
    "Type" => "Filespec"
    "UF" => "factur-x.xml"
  ]
}

$pdfParsed->getObjectsByType('EmbeddedFile'); is not empty. so lets get the first embeddedFile
foreach ($embeddedFiles as $embeddedFile) {
  $embeddedFile->getContent(); // returns Undefined variable $embeddedFile
}

expected Output should be that the variable $embeddedFile is not undefined.

Code

see above :)

Kind regards

[PrimeGhostDE]

Hi together,
is there something new to this?

[k00ni]

In your code the variable $embeddedFiles is never defined:

$pdfParsed->getObjectsByType('EmbeddedFile');
foreach ($embeddedFiles as $embeddedFile) {
  $embeddedFile->getContent(); // returns Undefined variable $embeddedFile
}

It should complain that $embeddedFiles is not defined. What happens when you do $embeddedFiles = $pdfParsed->getObjectsByType('EmbeddedFile') before the loop?

[PrimeGhostDE]

You are right.
I copied it to github without the assignment.
But it stays the same -> it does not work as expected.

$pdfParser = new PdfParser();
$pdfContent = file_get_contents(Storage::path($dokument->path . '/' . $dokument->filename));
$pdfParsed = $pdfParser->parseContent($pdfContent);
$embeddedFiles = $pdfParsed->getObjectsByType('EmbeddedFile');
dd($embeddedFiles); // returns array without any elements.

it does not get into the foreach.

[ds-ek09]

Same problem here, pdf clearly had attachments, but EmbeddedFiles was empty. Dumped some PDFObjects and Headers and it turned out that in these PDFs the attachments seem to be stored in a different way. Not a PDF guy, so no idea why and if that should be supported by smalot.

Here is how to get the XML Content:

        foreach ($filespecs as $filespec) {
            $filespecDetails = $filespec->getDetails();
            if (in_array($filespecDetails['F'], static::ATTACHMENT_FILENAMES)) {
                $attachmentFound = true;

                if(count($pdfParsed->getObjectsByType('EmbeddedFile')) == 0) {
                    if($filespec->getHeader()->has('EF') && $filespec->getHeader()->get('EF')->has('F')) {
                        $content = $filespec->getHeader()->get('EF')->get('F')->getContent();
                        return $content;
                    }
                }
                
                break;
            }
            $attachmentIndex++;
        }

Was able to parse your PDF and extract the XML. Hope that helps.

[SourcePot]

horstoeko\zugferd\ZugferdDocumentPdfReader::readAndGuessFromFile() requires smalot/pdfparser and uses EmbeddedFile to extract embedded xml invoice files. I experienced some pdf-documents (XRechnung) where method readAndGuessFromFile failed and EmbeddedFile was empty, even if an xml file was embedded in the pdf. The workaround outlined by [ds-ek09] works very well as a quick fix.