Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo #1056 #1072

Closed
wants to merge 5 commits into from
Closed

Logo #1056 #1072

wants to merge 5 commits into from

Conversation

ishitakapoor26
Copy link

Fixes #1056

@vercel
Copy link

vercel bot commented Jul 8, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/smaranjitghose/doc2pen/6siKz4g4nt6kdj65BeSGTxQnem9P
✅ Preview: https://doc2pen-git-fork-ishitakapoor26-ik-smaranjitghose.vercel.app

@ishitakapoor26
Copy link
Author

@AbhipsaGuru1012 pls review pr.

@smaranjitghose
Copy link
Owner

Along with the gif could you please provide an SVG for the same?

@smaranjitghose smaranjitghose added LGMSOC21 Let's Grow More Summer of Code 2021 PR: reviewed-approved 🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21.Points will be 25. and removed PR: unreviewed labels Jul 8, 2021
@ishitakapoor26
Copy link
Author

Along with the gif could you please provide an SVG for the same?

yeah sure but animations won't work in svg format!

@smaranjitghose
Copy link
Owner

Along with the gif could you please provide an SVG for the same?

yeah sure but animations won't work in svg format!

Ya, I know. This is basically for other places where we can't have a gif file. Also, update the favicon for the page with this

@smaranjitghose smaranjitghose added 🟥 Level4 This issue will be considered as level 4 issue for LGM-SOC 21.Points will be 45. and removed 🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21.Points will be 25. labels Jul 8, 2021
@ishitakapoor26
Copy link
Author

I'm facing some issue in updating favicon to page, @AbhipsaGuru1012 can you please help?

@AbhipsaGuru1012
Copy link
Collaborator

I'm facing some issue in updating favicon to page, @AbhipsaGuru1012 can you please help?

@ishitakapoor26 yes please let me know what issue you are facing

smaranjitghose
smaranjitghose requested changes Jul 12, 2021
View reviewed changes
public/index.html Outdated
@@ -10,7 +10,7 @@
content="A student's savior to submit those assignments by just typing them out and getting it handwritten on the go!"
data-react-helmet="true" />
<link rel="preconnect" href="https://api.github.com">
<link rel="dynamic icon" id="favicon" href="doc2penlogo.png" />
<link rel="dynamic icon" id="favicon" href="src/assets/logo/DOC2PEN-favicon.gif" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this in the seo component built using react-helmet

@anushbhatia
Copy link
Collaborator

logo is too small so the text present inside is barely visible. Also in small devices it might not be that prominent so can you do something for that if possible.

@ishitakapoor26
Copy link
Author

logo is too small so the text present inside is barely visible. Also in small devices it might not be that prominent so can you do something for that if possible.

okay will make some changes to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ayushparikh-code Ayushparikh-code Ayushparikh-code approved these changes

@smaranjitghose smaranjitghose Awaiting requested review from smaranjitghose

Assignees
No one assigned
Labels
🟥 Level4 This issue will be considered as level 4 issue for LGM-SOC 21.Points will be 45. LGMSOC21 Let's Grow More Summer of Code 2021 PR: partially-approved PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design Logo
5 participants
@ishitakapoor26 @smaranjitghose @AbhipsaGuru1012 @anushbhatia @Ayushparikh-code