-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to verify Bulgarian translations and add to translations file #17
Comments
Thank you for the translations effort. In reality, the goal for this app's was just to support translations. The English version should be fine but the rest is left to the users. The Spanish for example was mostly done via Google Translate an Bulgarian was added as prove of concept (because it uses Cyrillic characters and because most phrases are longer than in English). I intend to add some kind of configuration for choosing the supported languages and until then I can As for the "ACT"/"DESACT", can it become "ACT"/"DES"? This widget can fit up to 3 letters and if that is not enough it might have to be redesigned somehow. |
Thanks for the explanation! For the "DESACT" to "DES" idea, the translator was strong on keeping "DESACT", so there would be a change at this line to make it at least 83px to make the switch-button a little wider. |
Hi. First of all great job team. This app looks pretty nice. I am a native German speaker and actually, I think about how it is possible to do the translation stuff into german language. Is there a language file I can download to try translating the app into the German language? |
Currently, the app supports English, Spanish, and Bulgarian. There are a few problems I encountered coming across the translated phrases, particularly with Spanish. Some of the translations were direct-to-English translations, but had the wrong meaning. For example, in the current translations file, for the NICU toggle "ON" and "OFF", the Spanish translation is "EN" and "DE" respectively. But the more appropriate translation would be "ACTIVADO" and "DESACTIVADO", or "ACT." and "DESACT." for a truncated version.
Additionally, in one of my last PR's (#12) I added a new string that did not have a Bulgarian translation, as I don't have the resources to get a verified Bulgarian translation. There are also a few strings in the application that were not included in the translation files that remain as English throughout all language selections (ex: "See all" and "To here" in the table view).
I am currently working on getting the Spanish translations corrected with a Spanish translator, as well as tracking down some of the strings that were embedded in the code into the translation file. I'm hoping to leave this issue up in case in the future we can find someone to help verify correct Bulgarian translations, and hopefully add Bulgarian translations to missing strings.
The text was updated successfully, but these errors were encountered: