New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Validate that my client performs PKCE" not doing anything if client does not use PKCE #62

Open

imkacarlson opened this issue Jan 13, 2022 · 0 comments

imkacarlson commented Jan 13, 2022

Launching a FHIR server with this configuration:

https://smart.argo.run/?auth_error=&client_secret=&fhir_version_2=r4&iss=&jwks=&jwks_uri=&launch_pt=1&launch_url=&patient=&prov_skip_auth=1&provider=&pt_skip_auth=0&public_key=&redirect_uris=&sde=&token_lifetime=15&user_pt=&validate_pkce=1&validation_method=none

I'm imagining there should be some kind of error when I try and obtain the authorization code without using PKCE but it seems to still work:

https://smart.argo.run/v/r4/sim/eyJtIjoiMSIsImsiOiIxIn0/auth/authorize?client_id=client_id&response_type=code&scope=patient/Observation.rs&redirect_uri=http://localhost:8000/index.html&aud=https://smart.argo.run/v/r4/sim/eyJtIjoiMSIsImsiOiIxIn0/fhir&patient=87a339d0-8cae-418e-89c7-8651e6aab3c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment