Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging code is inconsistent #7

Open
tkng opened this issue Jan 6, 2017 · 1 comment
Open

logging code is inconsistent #7

tkng opened this issue Jan 6, 2017 · 1 comment

Comments

@tkng
Copy link
Contributor

tkng commented Jan 6, 2017

Currently, thumberd.go uses glog as a logging library, while thumbnail_magick.go sometimes uses log.Printf.

IMO using glog is enough, thus we can omit log.Printf from yoya-thumber.
@tkng
Copy link
Contributor Author

tkng commented Feb 22, 2017

I discussed with @yoya, We agreed to remove glog from yoya-thumber.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tkng