Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexer and parser files generated not matching those in smarty-php/smarty repository #1

Open
caucik opened this issue Feb 15, 2020 · 2 comments
Labels

Comments

@caucik
Copy link

caucik commented Feb 15, 2020

All 4 files generated using smarty-lexer differs from those shipped in smarty repository. Steps to reproduce:
mkdir /tmp/smarty-test
cd /tmp/smarty-test
git clone https://github.com/smarty-php/smarty.git
git clone https://github.com/smarty-php/smarty-lexer.git
cd smarty-lexer/
php Create_Template_Parser.php
php Create_Config_Parser.php
#now compare .bak versions with newly generated version - for templateparser:
diff ../smarty/lexer/smarty_internal_templateparser.php.bak ../smarty/libs/sysplugins/smarty_internal_templateparser.php
#same for 3 other files

@wisskid wisskid added the bug label Feb 16, 2020
@wisskid
Copy link
Contributor

wisskid commented Feb 16, 2020

I can confirm this. As far as I can tell, the differences are codestyle related, variable declarations being moved around et cetera. But I cannot find any smarty-lexer version that matches the existing version that is in smarty now. It seems Uwe used a newer version of smarty-lexer but did not push his local changes to github. Can you confirm this, @uwetews ?

@mvorisek
Copy link

This should be checked in CI in smarty-php/smarty repo to prevent this happening again. PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants