Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN submission #6

Open
ThoDuyNguyen opened this issue Mar 21, 2017 · 3 comments
Open

CRAN submission #6

ThoDuyNguyen opened this issue Mar 21, 2017 · 3 comments

Comments

@ThoDuyNguyen
Copy link

Hi @smbache

The package is very useful and I used it a lot in my production code.

Have you got a plan to submit the package to CRAN?

Kind regards

@smbache
Copy link
Owner

smbache commented Mar 21, 2017

I'd also like a submission - but I'm a bit unhappy with the speed of inserting due to the DBI::sql_interpolate call which is there for security. Not sure how I want to solve that currently. Maybe I can use it better, but maybe I'd have to write something else, but that would be unfortunate I think.

@ThoDuyNguyen
Copy link
Author

Actually it was hard to find this package and I found out it only when I browse your repository (as author of magittr). I think in most cases, data analysts query data from a database rather than inserting high volume of data. On the other hand, when the package gets popular, many people would contribute to solve the existing issues.

Just my 2c.

Kind regards

@joranE
Copy link

joranE commented Sep 18, 2017

Is it really necessary to use DBI::sql_interpolate rather than using DBI::dbQuoteString directly which is vectorized?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants