Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File data/init.conf was deleted from the repository, but many other files still reference it #67

Closed
izuzak opened this issue Dec 29, 2024 · 0 comments · Fixed by #70
Closed

File data/init.conf was deleted from the repository, but many other files still reference it #67

izuzak opened this issue Dec 29, 2024 · 0 comments · Fixed by #70
Labels
bug Something isn't working

Comments

@izuzak
Copy link
Contributor

izuzak commented Dec 29, 2024

Describe the bug

As far as I can tell, #58 deleted the data/init.conf file, but many other files in the repository still reference data/init.conf.

For example, I just tried running make setup-dotfiles and it failed with:

> make setup-dotfiles

mkdir -p $HOME/.ad/mnt
[ -f $HOME/.ad/init.conf ] && mv $HOME/.ad/init.conf $HOME/.ad/init.conf.bck || true
cp data/init.conf $HOME/.ad
cp: data/init.conf: No such file or directory
make: *** [copy-default-config] Error 1

To Reproduce

Steps to reproduce the behavior:

  1. run make setup-dotfiles
  2. observe error due to data/init.conf missing

Expected behavior

No errors 😸

Versions & OS Details

OS: macOS 15.2 (24C101)
ad Version: built from source, commit da57f60
@izuzak izuzak added the bug Something isn't working label Dec 29, 2024
edersohe added a commit to edersohe/ad that referenced this issue Jan 2, 2025
@edersohe
fix(config): update init.conf file references to config.toml
16aa186 
Updated all references from init.conf to config.toml in various files
including Makefile, help-template.txt, edit-landing-on-gap-end.txt,
fsys, structural-regex-reformatting.txt, and built_in_commands.rs.

Fixes: sminez#67
@edersohe edersohe mentioned this issue Jan 2, 2025
Merged
@sminez sminez closed this as completed in #70 Jan 5, 2025
sminez added a commit that referenced this issue Jan 5, 2025
@sminez
Merge pull request #70 from edersohe/develop
55d3a78 
fix(config): update init.conf file references to config.toml, fixes: #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(config): update init.conf file references to config.toml, fixes: #67 edersohe/ad
1 participant
@izuzak