Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AWS_ENDPOINT_URL environment variable #2863

Open
Aaron1011 opened this issue Jul 20, 2023 · 1 comment
Open

Support AWS_ENDPOINT_URL environment variable #2863

Aaron1011 opened this issue Jul 20, 2023 · 1 comment
Assignees
@Velfi
Labels
customer-request sdk

Comments

@Aaron1011
Copy link

Currently, the only way to override the endpoint URL is by using the ConfigLoader::endpoint_url method: https://docs.rs/aws-config/latest/aws_config/struct.ConfigLoader.html#method.endpoint_url

Recently, the AWS CLI added support for using theAWS_ENDPOINT_URL env var for overriding the endpoint URL: aws/aws-cli#1270 (comment)

It would be very useful to have support for this in aws-config
@jdisanti
Copy link
Collaborator

This feature is planned, although it may be a while before we get to it.

@Velfi Velfi mentioned this issue Mar 28, 2024
Merged
1 task
github-merge-queue bot pushed a commit that referenced this issue Apr 1, 2024
@Velfi @jdisanti @ysaito1001
Sourcing service config from the environment. (#3493)
5f7113f 
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here -->
#2863
awslabs/aws-sdk-rust#1060

## Description
<!--- Describe your changes in detail -->
This PR adds a new feature: the ability to source service-specific
config from the environment.
This is **only** supported when creating a service config from an
`SdkConfig`. I've posted [a
guide](#3537) to our
discussions board.

[This also adds support for setting an endpoint URL in environment
config.](#2863)

## Testing
<!--- Please describe in detail how you tested your changes -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
I have written several tests ensuring config is extracted with the
correct precedence.

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: John DiSanti <[email protected]>
Co-authored-by: ysaito1001 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Velfi Velfi

Labels
customer-request sdk
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdisanti @Aaron1011 @Velfi