Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More modularization for metrics and logs #50

Open
anvari1313 opened this issue Oct 3, 2022 · 3 comments
Open

More modularization for metrics and logs #50

anvari1313 opened this issue Oct 3, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@anvari1313
Copy link
Member

It's a good idea to make some functionalities like Prometheus metrics and logging modular and enable the users to customize them in their own way.

@amirhnajafiz
Copy link
Member

@anvari1313 jan, I'm sure that @mehditeymorian jan can explain this with more details and accurately but
we had this plan to add a logger interface in qsse, so users can use their own customized logger module, but unfortunately we couldn't find anything to use as an interface.
Do you have any ideas of how we can replace for example zap logger with a global interface?

Our idea was to develop our own global logger interface but it might take a long time to come with a stable and useful interface.

@1995parham
Copy link
Member

Yes, exactly right now Golang doesn't have any standard logger interface that support structured logging, so we force using zap as logger but for the Prometheus part I think open-telemetry metrics interface is great solution. If all agree, we can use that.

@1995parham 1995parham added the enhancement New feature or request label Oct 5, 2022
@anvari1313
Copy link
Member Author

Or we can think about implementing an interceptor-like pattern in the project to make it extendable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants