Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Port Building #266

Open
impeeza opened this issue Aug 17, 2023 · 1 comment
Open

Switch Port Building #266

impeeza opened this issue Aug 17, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@impeeza
Copy link

impeeza commented Aug 17, 2023 •
edited
Loading

Describe your bug here. And how to reproduce it.

Hello there, with the latest commit, trying to build the switch port you get this errors:

image

tested on Windows with MSYS with DevKitPro and Ubuntu

same error

thanks a lot for your work.

I just noted, before commit 43db8cc, the files:

  • attract.c
  • audio.c
  • dungeon.c
  • ending.c
  • load_gfx.c
  • messaging.c
  • misc.c
  • nmi.c
  • overworld.c
  • player_oam.c
  • select_file.c
  • tagalong.c
  • zelda_cpu_infra.c
  • zelda_rtl.c

was on repo root, so the reference #include "snes/snes_regs.h" was valid, but now these files are on src directory, so the reference is not valid now, should be #include "../snes/snes_regs.h" or something more generic.

What is your build target?

Switch
@impeeza impeeza added the bug Something isn't working label Aug 17, 2023
@impeeza impeeza mentioned this issue Aug 27, 2023
Closed
impeeza added a commit to impeeza/zelda3 that referenced this issue Aug 31, 2023
@impeeza
Update Makefile to accommodate to new directory structure.
0cffca2 
A set of small changes to accommodate to new directory setup.

Now builds Switch version without problem, and solves snesrev#266

Thanks a lot to @godreborn to help diagnose the problem here and SMW repo.
@impeeza impeeza mentioned this issue Aug 31, 2023
Open
@impeeza
Copy link
Author

impeeza commented Oct 23, 2023

Hello there @snesrev, any update on this?

@Rai Rai mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@impeeza