Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support excluding samples for PeakDensity correspondence #742

Open
jorainer opened this issue Apr 23, 2024 · 0 comments
Open

Support excluding samples for PeakDensity correspondence #742

jorainer opened this issue Apr 23, 2024 · 0 comments
Assignees
@jorainer

Comments

@jorainer
Copy link
Collaborator

Sometimes it might not be needed/wanted to define features with detected peaks in all sample groups. For examples with blanks it might for example be better to exclude them from feature definitions since features with chromatographic peak present only in blanks might not be of interest.

So, we might want support for sampleGroups being a factor with an NA for samples that should be excluded from the feature definition.
@jorainer jorainer self-assigned this Apr 24, 2024
jorainer added a commit that referenced this issue Apr 24, 2024
@jorainer
feat: allow exclusion of samples/groups from feature definition
ea35751 
- Support exclusion of samples/groups from the definition of new features with
  the *PeakDensity* method by using a value of `NA` for them with the
  `sampleGroups` parameter (issue #742).
@jorainer jorainer mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorainer jorainer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jorainer