New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Body of notification not sent #12

Open

clindh opened this issue Nov 17, 2016 · 1 comment

clindh commented Nov 17, 2016

In Notification::jsonSerialize there is an error, causing "body" not to be added to jsonData if there is no title set

public function jsonSerialize()
    {
...
        if ($this->title) {
            $jsonData['body'] = $this->body;
        }

The text was updated successfully, but these errors were encountered:

Contributor

johann59 commented Nov 18, 2016 •

edited

Loading

Hi I'll think it's because you have the same test for title and body,
a PR will be here if you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment