Skip to content

Convert Form::select to blade component #16065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 7, 2025

Conversation

marcusmoore
Copy link
Collaborator

@marcusmoore marcusmoore commented Jan 14, 2025

Copy link

what-the-diff bot commented Jan 14, 2025

PR Summary

  • Implemented a New Blade Component:

    • Introduced a new component for dropdown selections, simplifying the code and improving readability.
  • Transitioned to Custom Component:

    • Several select elements throughout the application have been updated to use the new component. These updates were made in various areas including category type selection, status identification, and more.
  • Improved Dropdown Functionality:

    • The custom component enhances the management of options and selected states, driving efficiency by promoting code reuse.
  • Incorporated Livewire for Real-Time Updates:

    • Many instances now include attributes for Livewire functionality, enhancing real-time form updates.
  • Enhanced Error Handling:

    • Revised the error handling process to remain effective while simplifying select element definitions.
  • Overall Code Refactoring:

    • Removal of repetitive code reduces complexity and improves maintainability across forms using selections.
  • Deprecated Files Removal:

    • Certain files, like category.blade.php, company.blade.php and others, were deleted possibly as part of a refactoring or consolidation process.
  • Utilization of new Component in Various Views:

    • Form elements in branding.blade.php, various edit view files and settings related to dashboard configuration have migrated to using the new component, improving the user experience.
  • Increased Accessibility:

    • The new component also includes an aria-label for improved accessibility. This entails that the component is better suited for users with special needs.

Copy link
Member

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have a few conflicts here too and it won't let me resolve - can you clean those up?

# Conflicts:
#	resources/views/partials/forms/edit/company.blade.php
@marcusmoore
Copy link
Collaborator Author

Resolved conflict 👍🏾

@marcusmoore marcusmoore requested a review from snipe February 10, 2025 23:48
@snipe
Copy link
Member

snipe commented Mar 4, 2025

A few more conflicts due to @Godmartinz's localization changes

@marcusmoore
Copy link
Collaborator Author

@snipe would you like this re-submitted in smaller chunks?

@snipe
Copy link
Member

snipe commented Mar 4, 2025

I don’t think I need that, unless it makes you feel more comfortable. I’m basically ready to merge it once the conflicts are handled.

@marcusmoore
Copy link
Collaborator Author

Sounds good. I'll handle the merge conflicts.

# Conflicts:
#	resources/views/settings/branding.blade.php
#	resources/views/settings/general.blade.php
@marcusmoore
Copy link
Collaborator Author

@snipe merge conflicts are handled. Test failures are due to other issues (one of which I'm working on).

@snipe
Copy link
Member

snipe commented Mar 5, 2025

I keep re-running these tests (they were fixed already) but they're still failing :-/

@marcusmoore
Copy link
Collaborator Author

I'll take a look

@marcusmoore
Copy link
Collaborator Author

@snipe back to green 👍🏾

@snipe snipe merged commit 33c9ea4 into grokability:develop Mar 7, 2025
9 checks passed
@marcusmoore marcusmoore deleted the chore/migrate-select-helper branch March 10, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants