-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Convert Form::select to blade component #16065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Form::select to blade component #16065
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have a few conflicts here too and it won't let me resolve - can you clean those up?
# Conflicts: # resources/views/partials/forms/edit/company.blade.php
Resolved conflict 👍🏾 |
A few more conflicts due to @Godmartinz's localization changes |
@snipe would you like this re-submitted in smaller chunks? |
I don’t think I need that, unless it makes you feel more comfortable. I’m basically ready to merge it once the conflicts are handled. |
Sounds good. I'll handle the merge conflicts. |
# Conflicts: # resources/views/settings/branding.blade.php # resources/views/settings/general.blade.php
@snipe merge conflicts are handled. Test failures are due to other issues (one of which I'm working on). |
I keep re-running these tests (they were fixed already) but they're still failing :-/ |
I'll take a look |
@snipe back to green 👍🏾 |
This PR introduces the
<x-input.select>
blade component and uses it to replaceForm::select()
usage in our blade templates.Pages affected
Assets
Asset Models
Categories
Custom Fields
Custom Fieldsets
Imports
Licenses
Settings
Status Labels
Users
Modals affected
Extracted via copy/paste from #15983.