Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-921006 Add HTTPS wiremock with custom CA #1324

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Mar 5, 2025

Description

SNOW-921006 Added a test scenario for HTTPS on wiremock.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

gitguardian bot commented Mar 5, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15854709 Triggered Generic Private Key 6cb5d2b ci/scripts/wiremock.key View secret
🛠 Guidelines to remediate hardcoded secrets

The above secret(s) have been detected in your PR. Please take an appropriate action for each secret:

  • If it’s a true positive, remove the secret from source code, revoke it and migrate to a secure way of storing and accessing secrets (see http://go/secrets-and-code). Once that’s done, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and resolve the incident.
  • If it’s a false positive, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and ignore the incident.
  • If you didn't add this secret - and only then - you may ignore this check as it's non-blocking. If you did add the secret and you ignore this check, you'll be assigned a "Security Finding" ticket in Jira in a few days.

Note:

  • A secret is considered leaked from the moment it touches GitHub. Rewriting git history by force pushing or other means is not necessary and doesn’t change the fact that the secret has to be revoked.
  • This check has a “Skip: false positive” button. Don’t use it. It will mark all detected secrets as false positives but only in the context of this specific run - it won’t remember this action in subsequent check runs.

If you encounter any problems you can reach out to us on Slack: #gitguardian-secret-scanning-help


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-921006-wiremock-https-test branch 3 times, most recently from c1ebcf9 to a3b21d7 Compare March 5, 2025 13:00
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-921006-wiremock-https-test branch from a3b21d7 to 6cb5d2b Compare March 5, 2025 14:04
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review March 5, 2025 14:05
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner March 5, 2025 14:05
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.07%. Comparing base (b034584) to head (b1b2d9f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
- Coverage   82.09%   82.07%   -0.03%     
==========================================
  Files          55       55              
  Lines       13722    13722              
==========================================
- Hits        11265    11262       -3     
- Misses       2457     2460       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-pfus sfc-gh-pfus merged commit f388736 into master Mar 6, 2025
38 of 39 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-921006-wiremock-https-test branch March 6, 2025 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants