Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1795105: SNOW-864140 Issues building the code #774

Open
rob2244 opened this issue Nov 9, 2024 · 8 comments
Open

SNOW-1795105: SNOW-864140 Issues building the code #774

rob2244 opened this issue Nov 9, 2024 · 8 comments
Assignees
Labels
question Issue is a usage/other question rather than a bug status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team

Comments

@rob2244
Copy link

rob2244 commented Nov 9, 2024

  1. What version of libsnowflakeclient are you using?
    1.1.0

  2. What operating system and processor architecture are you using?
    Ubuntu 24.04.1 LTS AMD64

  3. What version of C complier are you using?
    gcc 13.2.0

  4. What did you do?
    I ran the build script ./scripts/build_libsnowflakeclient.sh and am getting errors about missing dependencies.
    image
    I then ran the ./scripts/build_dependencies.sh but it looks like it doesn't build all the dependencies.
    After the dependency build
    image
    Some more context: I'm sorry if I'm doing something wrong, I'm fairly new to C++. I'm trying to build a duckdb snowflake extension and am trying to include this library in my CMake project. I'm not sure what the best way to do this is. Would appreciate any pointers or examples you could provide.

  5. What did you expect to see?
    I expected the build to succeed and the artifacts to be generated

@rob2244 rob2244 added the bug Something isn't working label Nov 9, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Nov 11, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage Issue is under initial triage and removed bug Something isn't working labels Nov 11, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka changed the title Issues building the code SNOW-1795105 Issues building the code Nov 11, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added question Issue is a usage/other question rather than a bug status-triage_done Initial triage done, will be further handled by the driver team and removed status-triage Issue is under initial triage labels Nov 11, 2024
@sfc-gh-dszmolka
Copy link
Contributor

thank you for raising this - i was also struggling a little bit with various attempts but cannot seem to make it work outside of Snowflake CI. Discussing with the team what are the working build steps and will update accordingly.

@sfc-gh-dszmolka sfc-gh-dszmolka changed the title SNOW-1795105 Issues building the code SNOW-1795105: SNOW-864140 Issues building the code Nov 12, 2024
@sfc-gh-dszmolka
Copy link
Contributor

while this is under fixing / documentation, dev team provided the following workaround. Would it be possible for you to please try?
It worked for them on arm64v8/ubuntu:24.04 image, using dev branch https://github.com/snowflakedb/libsnowflakeclient/tree/SNOW-864140-build-on-ubuntu-24.04 of the library, and the following steps:

  • install g++: apt install g++
  • run build_dependencies.sh
  • run build_libsnowflakeclient.sh

hope it works for you and can get you unblocked but please let us know.

@rob2244
Copy link
Author

rob2244 commented Nov 16, 2024

Looks like it worked thanks! Am i right in guessing I need to link in the static library built under libsnowflakeclient/deps-build/linux/Release/libsnowflakeclient/lib into my cmake project?

@sfc-gh-dszmolka
Copy link
Contributor

(https://github.com/snowflakedb/libsnowflakeclient/tree/SNOW-864140-update-build-scripts-instruction has now the working version for Linux and Windows; fixing the Mac steps is in progress before merging the change)

@rob2244
Copy link
Author

rob2244 commented Nov 27, 2024

@sfc-gh-dszmolka awesome thanks! Is there any docs or examples on library use anywhere? I was looking in the examples folder but it seems like it only has an example for creating the conn

@rob2244
Copy link
Author

rob2244 commented Nov 27, 2024

@sfc-gh-dszmolka awesome thanks! Is there any docs or examples on library use anywhere? I was looking in the examples folder but it seems like it only has an example for creating the conn

nvm, think I can figure it out from the code docs in the header files, thanks!

@sfc-gh-dszmolka sfc-gh-dszmolka added status-pr_pending_merge A PR is made and is under review status-in_progress Issue is worked on by the driver team and removed status-pr_pending_merge A PR is made and is under review labels Nov 27, 2024
@sfc-gh-dszmolka
Copy link
Contributor

#785

@sfc-gh-dszmolka sfc-gh-dszmolka added status-pr_pending_merge A PR is made and is under review and removed status-in_progress Issue is worked on by the driver team labels Dec 5, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-pr_pending_merge A PR is made and is under review labels Dec 16, 2024
@sfc-gh-dszmolka
Copy link
Contributor

PR is merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issue is a usage/other question rather than a bug status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Development

No branches or pull requests

3 participants