Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-692968: Async queries support #787

Merged
merged 62 commits into from
Mar 5, 2025
Merged

SNOW-692968: Async queries support #787

merged 62 commits into from
Mar 5, 2025
+806 −132

Conversation

sfc-gh-ext-simba-nl
Copy link
Collaborator

Added snowflake_async_execute to execute async queries and snowflake_async_stmt to get previously run async queries using query id.

sfc-gh-ext-simba-hx
sfc-gh-ext-simba-hx reviewed Dec 2, 2024
View reviewed changes
sfc-gh-ext-simba-hx
sfc-gh-ext-simba-hx reviewed Dec 2, 2024
View reviewed changes
sfc-gh-ext-simba-hx
sfc-gh-ext-simba-hx reviewed Dec 2, 2024
View reviewed changes
sfc-gh-ext-simba-hx
sfc-gh-ext-simba-hx reviewed Dec 2, 2024
View reviewed changes
sfc-gh-ext-simba-hx
sfc-gh-ext-simba-hx reviewed Dec 2, 2024
View reviewed changes
sfc-gh-ext-simba-hx
sfc-gh-ext-simba-hx reviewed Dec 2, 2024
View reviewed changes
sfc-gh-ext-simba-hx
sfc-gh-ext-simba-hx reviewed Dec 3, 2024
View reviewed changes
sfc-gh-ext-simba-hx
sfc-gh-ext-simba-hx reviewed Dec 3, 2024
View reviewed changes
@sfc-gh-ext-simba-nl sfc-gh-ext-simba-nl marked this pull request as ready for review December 10, 2024 21:16
@sfc-gh-ext-simba-nl sfc-gh-ext-simba-nl requested a review from a team as a code owner December 10, 2024 21:16
sfc-gh-jszczerbinski
sfc-gh-jszczerbinski requested changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unnecessary formatting changes. It's hard to review with so much (unnecessary?) changes.

sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Feb 7, 2025
View reviewed changes
sfc-gh-mkubik
sfc-gh-mkubik reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-mkubik sfc-gh-mkubik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We fixed the code quality check so now it can be turned green again so please take a look as well

@sfc-gh-ext-simba-nl
Copy link
Collaborator Author

sfc-gh-ext-simba-nl commented Feb 12, 2025 •
edited
Loading

Hi @sfc-gh-mkubik,
I looked at the code quality report and there's still many many errors and the logs still says "Baseline file does not exist."

Update: It works now

sfc-gh-jszczerbinski
sfc-gh-jszczerbinski requested changes Mar 4, 2025
View reviewed changes
sfc-gh-jszczerbinski
sfc-gh-jszczerbinski approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-nl sfc-gh-ext-simba-nl merged commit a502aee into master Mar 5, 2025
45 of 46 checks passed
@sfc-gh-ext-simba-nl sfc-gh-ext-simba-nl deleted the SNOW-692968-async-queries-support branch March 5, 2025 22:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz left review comments

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx left review comments

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski sfc-gh-jszczerbinski approved these changes

@sfc-gh-mmishchenko sfc-gh-mmishchenko sfc-gh-mmishchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sfc-gh-ext-simba-nl @sfc-gh-dprzybysz @sfc-gh-ext-simba-hx @sfc-gh-mkubik @sfc-gh-jszczerbinski @sfc-gh-mmishchenko