Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1634816: snow streamlit deploy --replace doesn't remove deleted files from the internal stage #1464

Open
ankitsr92 opened this issue Aug 21, 2024 · 1 comment
Labels
enhancement New feature or request streamlit

Comments

@ankitsr92
Copy link

SnowCLI version

2.7

Python version

Python 3.9.10

Platform

Linux-5.15.153.1-microsoft-standard-WSL2-x86_64-with-glibc2.31

What happened

On running snow streamlit deploy --replace, the current set of files in local env should be moved to Snowflake Internal Stage and the deleted files from local should get removed from internal stage.

Currently the files deleted from local still persists within the Snowflake Internal Stage.

Console output

No response

How to reproduce

Deploy a streamlit app with some sets of files.

Remove/Rename some files and re deploy.

Existing removed/renamed files will still exists in Snowflake

@github-actions github-actions bot changed the title snow streamlit deploy --replace doesn't remove deleted files from the internal stage SNOW-1634816: snow streamlit deploy --replace doesn't remove deleted files from the internal stage Aug 21, 2024
@sfc-gh-astus sfc-gh-astus added bug Something isn't working streamlit enhancement New feature or request and removed bug Something isn't working labels Aug 22, 2024
@sfc-gh-jduhart
Copy link

A customer surfaced this issue a few days ago as the orphaned objects left in the stage caused unexpected behavior. Perhaps we iterate through the staged files to check if they are still in the project? Or add a --clear-stage flag to remove all files before deployment? Would likely need a "protected files" manifest to prevent removal of files in the stage that may be used to maintain state, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request streamlit
Projects
None yet
Development

No branches or pull requests

3 participants