Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1050418: Refactor OktaAuthenticator to be object oriented #864

Open
SzymonSmykala opened this issue Feb 9, 2024 · 0 comments
Open

SNOW-1050418: Refactor OktaAuthenticator to be object oriented #864

SzymonSmykala opened this issue Feb 9, 2024 · 0 comments
Assignees
@sfc-gh-snow-drivers-warsaw-dl
Labels
enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team

Comments

@SzymonSmykala
Copy link

SzymonSmykala commented Feb 9, 2024 •
edited
Loading

To improve the code quality and maintainability, a refactor of the OktaAuthenticator class and its dependent classes is necessary. The current implementation suffers from high cognitive complexity, lack of unit tests, and non-standard field naming conventions. Additionally, having multiple classes within a single file.

The goals of the refactor are:

  • Enhance object-oriented design principles.
  • Reduce cognitive complexity.
  • Introduce unit tests to achieve 100% coverage.
  • Enforce naming conventions for fields and methods.

Out of scope:

  • Any functional changes
@github-actions github-actions bot changed the title Refactor OktaAuthenticator to be object oriented SNOW-1050418: Refactor OktaAuthenticator to be object oriented Feb 9, 2024
@SzymonSmykala SzymonSmykala mentioned this issue Feb 9, 2024
Open
6 tasks
@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature and removed bug labels Feb 9, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Feb 9, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage_done Initial triage done, will be further handled by the driver team label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-snow-drivers-warsaw-dl sfc-gh-snow-drivers-warsaw-dl

Labels
enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SzymonSmykala @sfc-gh-dszmolka @sfc-gh-snow-drivers-warsaw-dl