Remove extra newline from private key check

[CJxD]

4. What did you do?
   Didn't have an extra newline in my private key in my credentials.

5. What did you expect to see?
   It not to matter.

6. What did you see instead?

InvalidParameterError: Invalid private key. The specified value must be a string in pem format of type pkcs8

This took a lot of debugging to check if the key encryption was OK and the format could be read by OpenSSL, but it turned out to just be the lack of a newline.

The culprit is isPrivateKey in lib/utils.js

snowflake-connector-nodejs/lib/util.js

Lines 153 to 158 in 5bd5c13

	exports.isPrivateKey = function (value)
	{
	// The private key is expected to be decrypted when set in the connection string
	return (value.startsWith("-----BEGIN PRIVATE KEY-----") &&
	value.endsWith("\n-----END PRIVATE KEY-----\n"));
	};

which requires a newline at the end, and I can't imagine why it's necessary.

You've already got a regex based private key detector here

snowflake-connector-nodejs/lib/secret_detector.js

Line 72 in 7b3eaa9

const PRIVATE_KEY_PATTERN = new RegExp(String.raw`-----BEGIN PRIVATE KEY-----\\n([a-z0-9/+=\\n]{32,})\\n-----END PRIVATE KEY-----`,

[sfc-gh-dszmolka]

hi, thank you for submitting this issue and pinpointing where it happens. Checked and it seems that both the privateKey and privateKeyPath methods for keypair authentication are working well as described in Snowflake documentation for Using Key Pair Authentication & Key Pair Rotation.

however if one would paste the private key as a literal and try to use that with privateKey, it indeed breaks with the aforementioned error - until the newline character is introduced at the end of the key's footer, that is. we'll look into this and see if the private key detection could be made a bit more resilient.

[CJxD]

Thanks David :)

[sfc-gh-dszmolka]

#566

[sfc-gh-dszmolka]

PR is now merged and will be part of the next release; expected towards end of July

[sfc-gh-dszmolka]

PR is released as part of the latest Snowflake Node.JS driver version 1.7.0. Closing this issue.

[sfc-gh-dszmolka]

Releng team hit a bump in the release process which will be continued on Monday as expected. Reopening the issue and will only close when artifact confirmed to published to npm. Apologies for the inconvenience.

[sfc-gh-dszmolka]

PR is released as part of the latest Snowflake Node.JS driver version 1.7.0, for real this time :) Visible on npm too. Closing this issue and thank you for bearing with us !