Snow 855088 Set row mode array to mapping result set as array. Add suffix for duplicated columns during mapping to js objects.
#591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
reviewed
Jul 24, 2023
sfc-gh-pmotacki
force-pushed
the
SNOW-855088
branch
from
5938fac
to
fbb8c91
Compare
sfc-gh-pmotacki
changed the title
array to mapping result set as array. Add suffix for duplicated columns during mapping to js objects.
sfc-gh-pmotacki
force-pushed
the
SNOW-855088
branch
from
fbb8c91
to
d51c510
Compare
sfc-gh-dprzybysz
requested changes
Jul 24, 2023
Codecov Report
@@ Coverage Diff @@
## master #591 +/- ##
==========================================
+ Coverage 84.59% 84.78% +0.19%
==========================================
Files 54 56 +2
Lines 5135 5200 +65
==========================================
+ Hits 4344 4409 +65
Misses 791 791
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-pmotacki
force-pushed
the
SNOW-855088
branch
2 times, most recently
from
f6599bf
to
cc63674
Compare
sfc-gh-dprzybysz
requested changes
Jul 27, 2023
sfc-gh-pmotacki
force-pushed
the
SNOW-855088
branch
2 times, most recently
from
78741c8
to
753e9c0
Compare
|
Hell yes, I've been running a fork for two years for this change! 🎉 |
sfc-gh-pfus
reviewed
Jul 28, 2023
sfc-gh-dprzybysz
requested changes
Jul 28, 2023
sfc-gh-pmotacki
force-pushed
the
SNOW-855088
branch
from
2e1b2a9
to
9908bee
Compare
sfc-gh-pmotacki
force-pushed
the
SNOW-855088
branch
4 times, most recently
from
bd1fd7c
to
ebb81df
Compare
sfc-gh-pmotacki
force-pushed
the
SNOW-855088
branch
3 times, most recently
from
ed649e4
to
dffb5ec
Compare
sfc-gh-pmotacki
force-pushed
the
SNOW-855088
branch
from
dffb5ec
to
fae8e9b
Compare
sfc-gh-dprzybysz
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Execute select can contains in result duplicated column names. Because the result is mapped to javascript object so we lost elements for duplicated column names. After changes client can decide about mapping by setting a mode (object or array). For row mode 'object' and duplicated columns object keys will be suffixed with column identifiers.
Checklist
npm run lint:check -- CHANGED_FILESand fix problems in changed code)npm run test:unitandnpm run test:integration)