Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-875973: Prepare nodejs centos7 node14 docker image #597

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

Add centos7 with the latest node 14 docker images for build and test (they are equal for the internal CI process needs)

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner July 26, 2023 11:36
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-875973-prepare-nodejs-centos7-node14-docker-image branch from 26d76b7 to 6294a06 Compare July 26, 2023 11:41
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #597 (32010f9) into master (b5a7f3c) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is n/a.

❗ Current head 32010f9 differs from pull request most recent head eae6f4b. Consider uploading reports for the commit eae6f4b to get more accurate results

@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files          54       54           
  Lines        5135     5135           
=======================================
  Hits         4344     4344           
  Misses        791      791           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added only some questions to be sure that we would like to use always latest npm.

ci/image/Dockerfile.nodejs-centos7-node14-test Outdated Show resolved Hide resolved
ci/image/Dockerfile.nodejs-centos7-node14-build Outdated Show resolved Hide resolved
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-875973-prepare-nodejs-centos7-node14-docker-image branch from 6294a06 to 32010f9 Compare July 27, 2023 05:31
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-875973-prepare-nodejs-centos7-node14-docker-image branch 5 times, most recently from 6bba5ee to 1eeef84 Compare August 2, 2023 09:25
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 296f05a into master Aug 2, 2023
17 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-875973-prepare-nodejs-centos7-node14-docker-image branch August 2, 2023 09:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants