Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1215393: Test chunk fetching causing out of memory #793

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.66%. Comparing base (983b623) to head (378aaea).
Report is 29 commits behind head on master.

Current head 378aaea differs from pull request most recent head 72bcd81

Please upload reports for the commit 72bcd81 to get more accurate results.

Files Patch % Lines
lib/connection/result/chunk.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #793       +/-   ##
===========================================
- Coverage   89.04%   47.66%   -41.38%     
===========================================
  Files          61       61               
  Lines        5867     5876        +9     
===========================================
- Hits         5224     2801     -2423     
- Misses        643     3075     +2432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1215393-test-chunk-fetching-causing-out-of-memory branch 3 times, most recently from 03f1300 to c28f2aa Compare March 11, 2024 08:06
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1215393-test-chunk-fetching-causing-out-of-memory branch from c28f2aa to 378aaea Compare March 11, 2024 08:45
Copy link

gitguardian bot commented Aug 23, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13510688 Triggered Generic Password dfb82b6 test/integration/testConnection.js View secret
🛠 Guidelines to remediate hardcoded secrets

The above secret(s) have been detected in your PR. Please take an appropriate action for each secret:

  • If it’s a true positive, remove the secret from source code, revoke it and migrate to a secure way of storing and accessing secrets (see http://go/secrets-and-code). Once that’s done, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and resolve the incident.
  • If it’s a false positive, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and ignore the incident.
  • If you didn't add this secret - and only then - you may ignore this check as it's non-blocking. If you did add the secret and you ignore this check, you'll be assigned a "Security Finding" ticket in Jira in a few days.

Note:

  • A secret is considered leaked from the moment it touches GitHub. Rewriting git history by force pushing or other means is not necessary and doesn’t change the fact that the secret has to be revoked.
  • This check has a “Skip: false positive” button. Don’t use it. It will mark all detected secrets as false positives but only in the context of this specific run - it won’t remember this action in subsequent check runs.

If you encounter any problems you can reach out to us on Slack: #gitguardian-secret-scanning-help


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants