SNOW-1332640 support reading of structured types #870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
reviewed
Jul 18, 2024
sfc-gh-pmotacki
changed the title
sfc-gh-pmotacki
force-pushed
the
SNOW-1332640-structured-types-support
branch
4 times, most recently
from
e69b365
to
9d3987a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #870 +/- ##
==========================================
+ Coverage 88.88% 88.99% +0.11%
==========================================
Files 65 66 +1
Lines 6304 6409 +105
==========================================
+ Hits 5603 5704 +101
- Misses 701 705 +4 ☔ View full report in Codecov by Sentry. |
sfc-gh-pfus
reviewed
Aug 2, 2024
sfc-gh-dheyman-1
approved these changes
Aug 21, 2024
lib/connection/result/column.js
Outdated
| value = convertTimestampTzString(columnValue, formatLtz, context.statementParameters['TIMEZONE'], column.getScale()).toSfDate(); | ||
| break; | ||
| case 'timestamp_ntz': | ||
| // context.format = context.statementParameters['TIMESTAMP_NTZ_OUTPUT_FORMAT'] || context.statementParameters['TIMESTAMP_OUTPUT_FORMAT']; |
There was a problem hiding this comment.
can we delete this comment?
There was a problem hiding this comment.
what is the file naming convention? I see that we use snake_case and camelCase at the same time
| ); | ||
| }); | ||
|
|
||
| // it('test nested object', function (done) { |
There was a problem hiding this comment.
why commented? do we need this?
test/integration/testConnection.js
Outdated
| @@ -46,7 +46,7 @@ describe('Connection test', function () { | |||
| assert.ok(!connection.isUp(), 'still active'); | |||
| }); | |||
|
|
|||
| it('Wrong Username', function (done) { | |||
| it.skip('Wrong Username', function (done) { | |||
There was a problem hiding this comment.
Why do we skip this test?
| complete: function (err, stmt, rows) { | ||
| testUtil.checkError(err); | ||
| const row = rows[0]; | ||
| const narmalizedRow = {}; |
There was a problem hiding this comment.
Typo narmalized instead of normalized.
| complete: function (err, stmt, rows) { | ||
| testUtil.checkError(err); | ||
| const row = rows[0]; | ||
| const narmalizedRow = {}; |
sfc-gh-pbulawa
approved these changes
Sep 3, 2024
sfc-gh-pmotacki
force-pushed
the
SNOW-1332640-structured-types-support
branch
from
33507d1
to
0fbb24e
Compare
|
Added to changes in feather branch - PR #874 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist
npm run lint:check -- CHANGED_FILESand fix problems in changed code)npm run test:unitandnpm run test:integration)