Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPS-45767] Add a way for an externalBrowserCallback to be passed in to connection parameters #910

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sfc-gh-klin
Copy link
Contributor

@sfc-gh-klin sfc-gh-klin commented Sep 12, 2024

Since January 2023, the VS Code extension for Snowflake has patched in a way to use an externalBrowserCallback to the snowflake-connector-nodejs code so that VS Code API function openExternal can be passed in as the method to open the SSO url. This is because a subset of users experience SSO issues otherwise. For example, users using dev containers seem to have some kind of set up (perhaps proxy settings or other things) that make it so that VS Code's openExternal works but the npm open package does not.

APPS-19052

I'd like to propose explicitly adding this connection config param to the snowflake-connector-nodejs for easier maintainability.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (b83eba4) to head (981ce30).

Files with missing lines Patch % Lines
lib/authentication/auth_idtoken.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
+ Coverage   88.75%   88.94%   +0.19%     
==========================================
  Files          65       65              
  Lines        6304     6306       +2     
==========================================
+ Hits         5595     5609      +14     
+ Misses        709      697      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant