[APPS-45767] Add a way for an externalBrowserCallback to be passed in to connection parameters #910
+10
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since January 2023, the VS Code extension for Snowflake has patched in a way to use an externalBrowserCallback to the snowflake-connector-nodejs code so that VS Code API function openExternal can be passed in as the method to open the SSO url. This is because a subset of users experience SSO issues otherwise. For example, users using dev containers seem to have some kind of set up (perhaps proxy settings or other things) that make it so that VS Code's openExternal works but the npm open package does not.
APPS-19052
I'd like to propose explicitly adding this connection config param to the snowflake-connector-nodejs for easier maintainability.
Checklist
npm run lint:check -- CHANGED_FILES
and fix problems in changed code)npm run test:unit
andnpm run test:integration
)