Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): Missing declaration for OFF as LogLevel #912

Merged

Conversation

ovr
Copy link
Contributor

@ovr ovr commented Sep 16, 2024

I believe it was missed. It's declared in the documentation and used in the source code.

Thanks

@ovr ovr requested a review from a team as a code owner September 16, 2024 14:27
Copy link

github-actions bot commented Sep 16, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ovr
Copy link
Contributor Author

ovr commented Sep 16, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pmotacki sfc-gh-pmotacki merged commit b624a8f into snowflakedb:master Sep 23, 2024
55 of 92 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants