Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-952788 remove support for node 14 and 16 #934

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sfc-gh-akolodziejczyk
Copy link
Contributor

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk commented Oct 9, 2024

Description

SNOW-952788

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (d7e518a) to head (1c3d145).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
- Coverage   89.06%   88.89%   -0.18%     
==========================================
  Files          66       66              
  Lines        6455     6455              
==========================================
- Hits         5749     5738      -11     
- Misses        706      717      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk marked this pull request as ready for review October 9, 2024 13:17
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk requested a review from a team as a code owner October 9, 2024 13:17
@sfc-gh-pmotacki
Copy link
Collaborator

The suggestion is to wait to remove builds for older versions until we release the driver and announce the end of support. WDYT @sfc-gh-akolodziejczyk ?

@sfc-gh-akolodziejczyk
Copy link
Contributor Author

The suggestion is to wait to remove builds for older versions until we release the driver and announce the end of support. WDYT @sfc-gh-akolodziejczyk ?

Ok, let's wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants