Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1769573: Support describeOnly #940

Open
gabegorelick opened this issue Oct 28, 2024 · 1 comment · May be fixed by #941
Open

SNOW-1769573: Support describeOnly #940

gabegorelick opened this issue Oct 28, 2024 · 1 comment · May be fixed by #941
Labels
enhancement The issue is a request for improvement or a new feature status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team

Comments

@gabegorelick
Copy link

What is the current behavior?

The NodeJS client does not currently support the describeOnly setting to run a describe only query.

What is the desired behavior?

connection.execute({ /* other options not shown */, describeOnly: true })

How would this improve snowflake-connector-nodejs?

Bring the NodeJS client up to parity with other clients like gosnowflake, Java, and .NET that support describeOnly.

References, Other Background

https://pkg.go.dev/github.com/snowflakedb/gosnowflake#WithDescribeOnly

https://github.com/snowflakedb/snowflake-jdbc/blob/83e5849103907f6b48a96c023233f2ca3e024a30/src/main/java/net/snowflake/client/core/SFStatement.java#L116

https://github.com/snowflakedb/snowflake-connector-net/blob/81995633744df22936f82e1d0f135b9b76f03945/Snowflake.Data/Core/SFStatement.cs#L223
@github-actions github-actions bot changed the title Support describeOnly SNOW-1769573: Support describeOnly Oct 28, 2024
gabegorelick added a commit to gabegorelick/snowflake-connector-nodejs that referenced this issue Oct 28, 2024
@gabegorelick
Add support for describeOnly
f6766a1 
Fixes snowflakedb#940
@gabegorelick gabegorelick linked a pull request Oct 28, 2024 that will close this issue
Open
5 tasks
@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team labels Oct 28, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

hi - thanks for raising this suggestion, and also the PR! the team will take a look.

@sfc-gh-pmotacki sfc-gh-pmotacki mentioned this issue Nov 4, 2024
Open
5 tasks
sfc-gh-pmotacki pushed a commit that referenced this issue Nov 4, 2024
@gabegorelick @sfc-gh-pmotacki
Add support for describeOnly
3b4fd32 
Fixes #940
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-pr_pending_merge A PR is made and is under review label Nov 5, 2024
sfc-gh-pmotacki pushed a commit that referenced this issue Nov 6, 2024
@gabegorelick @sfc-gh-pmotacki
Add support for describeOnly
ee96d2f 
Fixes #940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is a request for improvement or a new feature status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for describeOnly gabegorelick/snowflake-connector-nodejs
2 participants
@gabegorelick @sfc-gh-dszmolka