Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1530499: Bump urllib3 version to 2.2.2 #1997

Closed
sfc-gh-dbouassida opened this issue Jul 11, 2024 · 2 comments · May be fixed by #1998
Closed

SNOW-1530499: Bump urllib3 version to 2.2.2 #1997

sfc-gh-dbouassida opened this issue Jul 11, 2024 · 2 comments · May be fixed by #1998
Assignees
@sfc-gh-dbouassida
Labels
feature status-triage_done Initial triage done, will be further handled by the driver team

Comments

@sfc-gh-dbouassida
Copy link

What is the current behavior?

The current version of urllib3 used is 1.26.18.

What is the desired behavior?

Update the urllib3 version to 2.2.2.

How would this improve snowflake-connector-python?

The main feature of interest in urllib3 2.2.2 is the support for decompression of zstd when the content-encoding header is set to zstd. This update will allow the connector to handle zstd-encoded content.

References and other background

A PR with the new version will be created initially to check if all merge gates pass. This is primarily an experimental change to assess compatibility and improvements.
@github-actions github-actions bot changed the title Experiment with bumping urllib3 version to 2.2.2 SNOW-1530499: Experiment with bumping urllib3 version to 2.2.2 Jul 11, 2024
@sfc-gh-dbouassida sfc-gh-dbouassida mentioned this issue Jul 11, 2024
Open
7 tasks
@sfc-gh-dszmolka
Copy link
Contributor

No description provided.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage_done Initial triage done, will be further handled by the driver team and removed needs triage labels Jul 12, 2024
@GorbataiCristian GorbataiCristian mentioned this issue Aug 7, 2024
Closed
@topherinternational topherinternational mentioned this issue Aug 17, 2024
Merged
@sfc-gh-dbouassida sfc-gh-dbouassida changed the title SNOW-1530499: Experiment with bumping urllib3 version to 2.2.2 SNOW-1530499: Bump urllib3 version to 2.2.2 Sep 19, 2024
@jimmyxie-figma
Copy link

jimmyxie-figma commented Nov 5, 2024 •
edited
Loading

this is fixed in using python3.10
9f9c71e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-dbouassida sfc-gh-dbouassida

Labels
feature status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump urllib version to version 2.2.2 snowflakedb/snowflake-connector-python
3 participants
@sfc-gh-dszmolka @sfc-gh-dbouassida @jimmyxie-figma