-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessing StreamingIngestResponseCode
from the SFException
#601
Comments
Hi @joshtree41, thanks for creating the issue! We are now planning some error reporting improvements. Could you please describe your use case and why do you need the value of |
Hey @sfc-gh-lsembera, sweet sounds good. And yeah of course, here's some details: Currently in our pipelines - we'll use the following methods to insert data, check for validity, and/or check commit progress.
For any of these methods, we can get a Often times - in some warning or error log that is fired asynchronously and immediately proceeds the caught error, there will be a message with the Currently we have to go into the job logs and check the status codes that were fired in the warnings, but ideally we'd be able to access that information in the If we had access to the streaming response code, we could build out more actionable custom alerts and metrics into our pipelines. |
@joshtree41 It is not safe to assume that no data can be lost when status codes like 10 are returned. The safe way is to reopen the channel, check the last committed offset token and continue ingesting from there. These server-side response codes, while useful for debugging, are too burdensome to work with and we don't want our users to have to interpret dozens of server-side status codes. We are thinking about improving the error handling by categorising all errors into two groups:
What do you think, would this approach solve your issues with the SDK error codes? |
Haha I should have known you'd respond with that! Not to worry, we have a replay mechanism on our end for that scenario. What I have noticed though is that invalidations w/ QQ: What is status code 35? Don't see a description in the enum.
IMO - I'd rather just have the code attached - having a categorization into Transient/Transient invalidations/errors would be really useful as well, but you might as well just through the code in there too. I don't think it would be at all two cumbersome to have a method on the error that returns that actual error, in addition to a method or mechanism for getting the categorization. Having more information is better I think, it could help with debugging issues (even transient issues). |
Hey @sfc-gh-lsembera - any update here? Want me to provide more info for you guys? |
Hi @joshtree41, no need to provide any more info. I don't have ETA on this, yet. |
Hey @sfc-gh-lsembera - any update here? |
Hi @joshtree41, this issue hasn't been prioritized, yet. There is no decision, yet, if we are going to expose these internal codes. |
Okay cool, thanks @sfc-gh-lsembera. |
Hi team,
I think it might be useful if there a way that the StreamingIngestResponseCode could be accessed from the SFException.
Currently this exposes the
ErorrCode
message - but this a bit less useful I think.Some motivation behind this can be found in #547 (trying to diagnose and troubleshoot channel invalidations).
Let me know what you all think! I can provide more details if needed.
The text was updated successfully, but these errors were encountered: