Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1348192 SLF4J logging requires explicit configuration #1134

Open
futureviperowner opened this issue Sep 8, 2022 · 2 comments
Open

SNOW-1348192 SLF4J logging requires explicit configuration #1134

futureviperowner opened this issue Sep 8, 2022 · 2 comments
Assignees
Labels
question Issue is a usage/other question rather than a bug status-triage_done Initial triage done, will be further handled by the driver team

Comments

@futureviperowner
Copy link

Looking over the JDBC driver documentation for logging, it looks like I shouldn't have to explicitly tell the driver to use an SLF4J logger provided I have the necessary logger implementation on my classpath. However, that's not the behavior I'm observing. The snowflake driver is defaulting to the JDK14Logger in my project despite the presence of a StaticLoggerBinder. If I explicitly set the java system property, then it uses SLF4J. After reviewing the code for the driver, it looks to me like it's solely dependent on the java system property to make this decision.

Am I misunderstanding something or is the documentation incorrect?

@sfc-gh-igarish sfc-gh-igarish added the question Issue is a usage/other question rather than a bug label Feb 21, 2023
@sfc-gh-igarish
Copy link
Collaborator

Looks like you are right. Let me dig more and if there is no codeto use custom logger from classpath then we will change the doc. Thanks for reporting the issue.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage_done Initial triage done, will be further handled by the driver team and removed In-Progress labels Apr 26, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka changed the title SLF4J logging requires explicit configuration SNOW-1348192 SLF4J logging requires explicit configuration Apr 26, 2024
@sfc-gh-wfateem
Copy link
Collaborator

The documentation definitely needs to change as a starting point because this never worked in the manner described here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issue is a usage/other question rather than a bug status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Development

No branches or pull requests

7 participants