Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for custom conda channel for checking packages exist #125

Closed
wants to merge 1 commit into from

Conversation

danielhstahl
Copy link

@danielhstahl danielhstahl commented Oct 31, 2024

Currently, the Snowflake Conda channel is hardcoded. This is an issue in private/isolated environments that don't allow internet connectivity or when proxies such as JFrog are used.

This PR allows for an environment variable SNOWFLAKE_CONDA_CHANNEL_URL to be set for an alternative Conda channel such as a JFrog proxy.

Default behavior is unchanged.

@sfc-gh-wzhao
Copy link
Collaborator

Hi @danielhstahl ,
Thank you for your PR. However, this constant is used in many place other than get_matched_package_versions_in_snowflake_conda_channel function so they could not be changed. Furthermore, get_matched_package_versions_in_snowflake_conda_channel is designed as best-effort and non-blocking so it should not fail if that URL is not accessiable.

However, we are working on a change to replace get_matched_package_versions_in_snowflake_conda_channel with get_matched_package_versions_in_information_schema so that the package availablity check will always use information schema, making it easier to control.

@danielhstahl
Copy link
Author

Hi @danielhstahl , Thank you for your PR. However, this constant is used in many place other than get_matched_package_versions_in_snowflake_conda_channel function so they could not be changed. Furthermore, get_matched_package_versions_in_snowflake_conda_channel is designed as best-effort and non-blocking so it should not fail if that URL is not accessiable.

However, we are working on a change to replace get_matched_package_versions_in_snowflake_conda_channel with get_matched_package_versions_in_information_schema so that the package availablity check will always use information schema, making it easier to control.

Thank you. The problem is that the function will hang for 1-2 hours, even though the error itself doesn't break or block the flow. I can PR a workaround which uses a flag to ignore this function.

@danielhstahl
Copy link
Author

Opened a PR here: #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants