Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for list of specific roles as secondary roles #2761

Closed

Conversation

vkcelik
Copy link

@vkcelik vkcelik commented Dec 13, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    We needed to use specific roles as secondary roles but this was not supported, so I added support for it. No Jira issue

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.
    The "USE SECONDARY ROLES" command has support for one or more specific roles but it was not supported in the use_secondary_roles method. This PR adds support for it.

Copy link

github-actions bot commented Dec 13, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (vkcelik)[https://github.com/vkcelik]
@veli Kerim Celik
Veli Kerim Celik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@vkcelik
Copy link
Author

vkcelik commented Dec 13, 2024

I have read the CLA Document and I hereby sign the CLA

@vkcelik vkcelik closed this Dec 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant