Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1854327: fix test to exclude deleted nodes #2769

Merged

Conversation

sfc-gh-hojha
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1854327

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

We have a new commit in snowflakedb (https://github.com/snowflakedb/snowflake/pull/230405) where we stop showing deleted nodes. This test relies on old behavior where we do show deleted nodes. The fix is to update the test to not expect deleted nodes.

Copy link

github-actions bot commented Dec 17, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-hojha sfc-gh-hojha force-pushed the hojha-SNOW-1854327-fix-test-to-exclude-deleted-nodes branch from 512e163 to 9c1203a Compare December 17, 2024 20:42
@sfc-gh-hojha
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still failing?

@sfc-gh-hojha sfc-gh-hojha force-pushed the hojha-SNOW-1854327-fix-test-to-exclude-deleted-nodes branch from 9c1203a to 64af8ff Compare December 17, 2024 21:56
@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit e8e9c87 into main Dec 17, 2024
39 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the hojha-SNOW-1854327-fix-test-to-exclude-deleted-nodes branch December 17, 2024 22:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants