-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1722641: Add support for Series.between #2775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just fall back to native pandas, right?
Yes, but not in a way that causes extra materialization (the native pandas method just uses comparison operators and &, so we can preserve lazy evaluation). |
No, native pandas is not being used here. This was just falling back to modin implementation which itself routes to other supported Snowpark pandas methods (comparison operators). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Thanks, Jonathan!
0f4fda7
to
bcff17a
Compare
bcff17a
to
4039efb
Compare
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1722641
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Implements
Series.between
. The frontend implementation uses modin's implementation, which passes themodin.pandas.Series
object to the native pandas method, which directly uses comparison operators to implement the method.