Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redshift: Fix schemas with additionalProperties object getting duplicate columns #134

Closed
istreeter opened this issue Nov 9, 2022 · 1 comment

Comments

@istreeter
Copy link
Contributor

This issue was raised to us on Discourse.

For example, the Snowplow site_search schema has a field like this:

    "filters": {
      "type": "object",
      "additionalProperties": {
        "type": [
          "string",
          "boolean"
        ]
      }
    },

...it would yield two different columns called "filters" in the ddl:

 "filters"        VARCHAR(1024)  ENCODE ZSTD,                                                                                                                                                                                                                     
 "filters"        VARCHAR(4096)  ENCODE ZSTD, 

This only happens if additionalProperties is an object, not a boolean.

This might be related to #104 but it's not exactly the same, so I'm making it a different issue.

istreeter added a commit that referenced this issue Nov 9, 2022
istreeter added a commit that referenced this issue Nov 9, 2022
@istreeter
Copy link
Contributor Author

Duplicate of #55

@istreeter istreeter marked this as a duplicate of #55 Nov 9, 2022
voropaevp pushed a commit that referenced this issue Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant