Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't override managerRetryableException for tls manager #496

Open
Yuras opened this issue Nov 8, 2022 · 1 comment
Open

Can't override managerRetryableException for tls manager #496

Yuras opened this issue Nov 8, 2022 · 1 comment

Comments

@Yuras
Copy link
Collaborator

Yuras commented Nov 8, 2022

I tried to stop http-client from retrying on NoResponseDataReceived (see #495 for the context), but it didn't work:

  httpManager <- newTlsManagerWith $ tlsManagerSettings
    { managerRetryableException = \e -> traceShow e $
      case fromException e of
        Just (HttpExceptionRequest _ NoResponseDataReceived) -> False
        _ -> managerRetryableException defaultManagerSettings e
    }

I don't even see the trace. The reason is that here we fallback to the defaultManagerSettings instead of the provided settings. I'd expect something like this:

| otherwise -> managerRetryableException set e

instead of

| otherwise -> managerRetryableException defaultManagerSettings e
@Yuras
Copy link
Collaborator Author

Yuras commented Nov 8, 2022

I guess the same issue exists with managerRawConnection as well, though I didn't try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant