Fix ArgsBundler return type #67
Conversation
| @@ -15,7 +15,7 @@ | |||
| bundle.putParcelable(key, Parcels.wrap(value)); | |||
| } | |||
|
|
|||
| @Override public <V> V get(String key, Bundle bundle) { | |||
| @Override public Object get(String key, Bundle bundle) { | |||
There was a problem hiding this comment.
Are you sure that this is working properly? I mean, if we return here Object somewhere has to be a cast to the real class, right? By using generic methods <V> the compiler can determine what the actual return type is because Parcels.unwrap() knows <V> too.
There was a problem hiding this comment.
Ah, I've assembled test project and I see the problem now. I've updated the PR.
My proposition is to remove inferred return type from interface and add strict casting to generated code. Pros are obvious but there is one caveat. User can specify the inheritor of arg class and try to use the bundler for its super class. In this case we get ClassCastException in run time instead of compile time error. Although I don't think somebody will do something like that (only mistakenely maybe).
This should close #53